Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for aggregating streams protected by basic auth #93

Merged
merged 1 commit into from
Jul 10, 2015

Conversation

johanhaleby
Copy link
Contributor

It's now possible to specify streams like http://username:password@mydomain.org. Username and password is applied as basic auth.

For example -streams "http://johan:password@mydomain.org"

@benjchristensen
Copy link
Contributor

Thank you for contributing this. Changes look good to me.

Are you able to share information on your usage of Turbine 2.x? It's still not broadly talked about or used, since I created it primarily for the community and not internal Netflix usage (we have a bigger stream processing system now).

benjchristensen added a commit that referenced this pull request Jul 10, 2015
Added support for aggregating streams protected by basic auth
@benjchristensen benjchristensen merged commit 0e92405 into Netflix:2.x Jul 10, 2015
@spencergibb
Copy link

@benjchristensen Spring Cloud Netflix uses turbine 2 for aggregating hystrix streams via rabbitmq. I'm curious, what is you bigger stream processing system?

@johanhaleby
Copy link
Contributor Author

@benjchristensen We're currently not using it but we're thinking of doing so and that's why we need this feature (as well as SSL support which I'm currently working on). We're using Spring Cloud Hystrix which expose the Hystrix stream from the "management console" which is protected by basic auth. Since we have a couple of different services using Hystrix we figure we'd be using Turbine to combine them into single stream and hook up the Hystrix Dashboard to this stream. I suppose we would need some discovery mechanism as well later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants