Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #602. #670

Closed
wants to merge 3 commits into from
Closed

Fix #602. #670

wants to merge 3 commits into from

Conversation

csm
Copy link

@csm csm commented May 8, 2015

Fixes #602.

  • grails-app/controllers/com/netflix/asgard/ImageController.groovy (ImageDeleteCommand): remove configService. Call into grailsApplication.config directly, it appears that configService doesn't get autowired in this command.

* grails-app/controllers/com/netflix/asgard/ImageController.groovy (ImageDeleteCommand): remove `configService`. Call into grailsApplication.config directly, it appears that configService doesn't get autowired in this command.
@cloudbees-pull-request-builder

asgard-pull-requests #495 FAILURE
Looks like there's a problem with this pull request

@csm
Copy link
Author

csm commented May 8, 2015

I don't have any idea what failed, there aren't any details.

Note that this is against the 1.5.1 tag, so that could be it.

@cloudbees-pull-request-builder

asgard-pull-requests #496 FAILURE
Looks like there's a problem with this pull request

@csm
Copy link
Author

csm commented May 12, 2015

OK, now I have no clue what your builtbot is complaining about. The test results show zero failures, and zero codenarc issues. What's the deal?

@claymccoy
Copy link
Contributor

Looks like a compilation error:

Compilation error: startup failed:
/scratch/jenkins/workspace/asgard-pull-requests/grails-app/controllers/com/netflix/asgard/ImageController.groovy:
433: unexpected token: = @ line 433, column 17.
=
command.grailsApplication.config.promote?.targetServerRootUrls ?: []
^

On Tue, May 12, 2015 at 1:35 PM, Casey Marshall notifications@github.com
wrote:

OK, now I have no clue what your builtbot is complaining about. The
test results show zero failures, and zero codenarc issues. What's the deal?


Reply to this email directly or view it on GitHub
#670 (comment).

@cloudbees-pull-request-builder

asgard-pull-requests #497 SUCCESS
This pull request looks good

@csm
Copy link
Author

csm commented May 12, 2015

Indeed, that wasn't quite the way to split a long line in Groovy.

@csm csm closed this Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 500 when attempting to delete an AMI
4 participants