Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid crash when navigation keys used with an empty console #12

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: avoid crash when navigation keys used with an empty console #12

merged 1 commit into from
Feb 27, 2024

Conversation

mtb0x1
Copy link
Contributor

@mtb0x1 mtb0x1 commented Feb 27, 2024 •
edited
Loading

using navigation keys (up, down) with an empty console results in a panic with out-of-band error.

@jfernandez jfernandez self-requested a review February 27, 2024 16:11
jfernandez
jfernandez reviewed Feb 27, 2024
View reviewed changes
src/app.rs Show resolved Hide resolved
jfernandez
jfernandez requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@jfernandez jfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this and including unit tests. I just have one small request inlined.

@jfernandez jfernandez self-requested a review February 27, 2024 16:51
jfernandez
jfernandez approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@jfernandez jfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks.

@jfernandez jfernandez merged commit 352c617 into Netflix:main Feb 27, 2024
1 check passed
@nickodell
Copy link

@mtb0x1 Thanks for this fix. I ran into the same problem.

@mtb0x1 mtb0x1 mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfernandez jfernandez jfernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtb0x1 @nickodell @jfernandez