This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Replaced Hibernate Validator with Apache Bval #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyzhao
requested review from
kishorebanala,
apanicker-nflx and
falu2010-netflix
Pull Request Test Coverage Report for Build 3728
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #1543 +/- ##
============================================
+ Coverage 64.79% 64.98% +0.19%
+ Complexity 3412 3408 -4
============================================
Files 269 266 -3
Lines 15990 15978 -12
Branches 1442 1442
============================================
+ Hits 10360 10383 +23
+ Misses 4904 4869 -35
Partials 726 726
Continue to review full report at Codecov.
|
|
|
||
| <bean class="WorkflowTask" ignore-annotations="false"> | ||
| <class ignore-annotations="false"> | ||
| <constraint annotation="com.netflix.conductor.validations.WorkflowTaskTypeConstraint"/> |
There was a problem hiding this comment.
Is it possible to define these constraints in a class?
kishorebanala
approved these changes
Feb 23, 2020
falu2010-netflix
approved these changes
Feb 24, 2020
apanicker-nflx
approved these changes
Feb 24, 2020
apanicker-nflx
deleted the
replace-hibernate-validator-with-apache-bval
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.