Added multiple features in a specification ForkJoinSpec to verify the… #1691
Conversation
… fork join behavior
pctreddy
requested review from
kishorebanala,
AlejandroJorgePerez,
apanicker-nflx and
cyzhao
Pull Request Test Coverage Report for Build 4150
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## dev #1691 +/- ##
============================================
+ Coverage 64.71% 64.73% +0.01%
- Complexity 3724 3726 +2
============================================
Files 289 289
Lines 17788 17797 +9
Branches 1599 1603 +4
============================================
+ Hits 11511 11520 +9
+ Misses 5467 5466 -1
- Partials 810 811 +1
Continue to review full report at Codecov.
|
| @@ -0,0 +1,874 @@ | |||
| package com.netflix.counductor.integration.test | |||
There was a problem hiding this comment.
Please add license header.
| * End | ||
| */ | ||
| def "Test a simple workflow with fork join success flow"() { | ||
| setup: "Ensure that all the tasks involved in the workflow have a retry count of 0" |
There was a problem hiding this comment.
I believe this was done to maintain consistency with the existing JUnit tests, but this spec does not use/need modification of retry counts, so this could be removed.
There was a problem hiding this comment.
This was done before using the fork_join_workflow_without_retryable_tasks , this test can be changed to use a different workflow and the setup and cleanup are not needed.
| metadataService.updateTaskDef(persistedIntegrationTask2Definition) | ||
| } | ||
|
|
||
| def "Test restarting a failed fork join workflow"() { |
There was a problem hiding this comment.
restarting -> retrying
| when: "The workflow is retried" | ||
| workflowExecutor.retry(workflowInstanceId) | ||
|
|
||
| then: "verify that all the workflow is restarted and new tasks are added in place of the failed tasks" |
There was a problem hiding this comment.
restarted -> retried
… fork join behavior