Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Bugfix/support env variable task input param #929

Merged
merged 4 commits into from
Jan 7, 2019

Conversation

falu2010-netflix
Copy link
Contributor

@falu2010-netflix falu2010-netflix commented Jan 5, 2019

Description:

  • Added validation for environment variable used in WorkflowDef Task InputParam
  • Added validation for HTTP task such that http_request can be a part of inputTemplate or inputParameters.

@coveralls
Copy link

coveralls commented Jan 5, 2019

Pull Request Test Coverage Report for Build 2221

  • 63 of 78 (80.77%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 67.688%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/main/java/com/netflix/conductor/common/utils/EnvUtils.java 17 18 94.44%
common/src/main/java/com/netflix/conductor/common/utils/ConstraintParamUtil.java 32 46 69.57%
Files with Coverage Reduction New Missed Lines %
common/src/main/java/com/netflix/conductor/common/utils/ConstraintParamUtil.java 1 66.67%
Totals Coverage Status
Change from base Build 2215: -0.04%
Covered Lines: 8817
Relevant Lines: 13026

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #929 into dev will decrease coverage by 0.02%.
The diff coverage is 71.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #929      +/-   ##
===========================================
- Coverage     62.13%   62.1%   -0.03%     
- Complexity     2617    2627      +10     
===========================================
  Files           239     239              
  Lines         13011   13026      +15     
  Branches       1274    1284      +10     
===========================================
+ Hits           8084    8090       +6     
- Misses         4203    4213      +10     
+ Partials        724     723       -1
Impacted Files Coverage Δ Complexity Δ
...nductor/common/metadata/workflow/WorkflowTask.java 68.03% <ø> (ø) 80 <0> (ø) ⬇️
...flix/conductor/core/execution/ParametersUtils.java 88.65% <100%> (-0.59%) 31 <0> (-7)
...constraints/TaskReferenceNameUniqueConstraint.java 89.65% <100%> (+2.47%) 0 <0> (ø) ⬇️
...ix/conductor/common/utils/ConstraintParamUtil.java 58.33% <60.86%> (-16.67%) 10 <10> (+9)
...ductor/validations/WorkflowTaskTypeConstraint.java 85.18% <75%> (+0.05%) 0 <0> (ø) ⬇️
...a/com/netflix/conductor/common/utils/EnvUtils.java 88.88% <88.88%> (ø) 7 <7> (?)
.../com/netflix/conductor/grpc/server/GRPCServer.java 92.85% <0%> (+14.28%) 4% <0%> (ø) ⬇️
.../java/com/netflix/conductor/service/Lifecycle.java 60% <0%> (+30%) 3% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49df9a3...7eaca1d. Read the comment docs.

@falu2010-netflix falu2010-netflix changed the base branch from master to dev January 5, 2019 17:16
@falu2010-netflix falu2010-netflix merged commit b5a63b9 into dev Jan 7, 2019
@apanicker-nflx apanicker-nflx deleted the bugfix/support_env_variable_task_input_param branch January 15, 2019 01:18
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
…le_task_input_param

Bugfix/support env variable task input param
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants