Merge dev into v0.6 #742
Merged
Merge dev into v0.6 #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without proper cleanup, we risk leaking memory and having multiple owners overwriting the same memory.
Setup/cleanup (struct msg)->msg_info correctly
If we have metadata that exists for a key, but the key itself does not exist, we would previously get an ambiguous response with the status code 'E' but a (nul) value. This patchset deletes the metadata if this case is detected and returns status code 'X' to denote that the value does not exist. In normal operation, this ambiguous case should never happen, however, it can happen if read repairs had been disabled and then reenabled with live traffic between them. In this case, we don't want it to crash. This was found in a TEST cluster and I've confirmed that this fixes it.
Make scripts auto-cleanup stale metadata if detected
Turning on repairs with constant traffic runs the risk of in-flight queries trying to be repaired. This is incorrect and we should make sure to not take the repair path for these queries. This was found in a TEST cluster and I confirmed that this patch fixes it.
Turning on repairs shouldn't invoke repairs for in-flight queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.