Adding back the modified public constructor to DiscoveryClient #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue Netflix#174 added another argument to the constructor used by guice. This was considering the fact that code should not be using the @Inject constructor directly. However, some code inside Netflix was dependent on it. Adding the old constructor back and making the @Inject constructor package private.
|
eureka-pull-requests #208 SUCCESS |
NiteshKant
added a commit
that referenced
this pull request
Aug 27, 2014
Adding back the modified public constructor to DiscoveryClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #174 added another argument to the constructor used by guice.
This was considering the fact that code should not be using the @Inject constructor directly. However, some code inside Netflix was dependent on it.
Adding the old constructor back and making the @Inject constructor package private.