Adding auth headers #142
Merged
Adding auth headers #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eureka-pull-requests #143 SUCCESS |
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| public abstract class AbstractEurekaAuthInfo { |
There was a problem hiding this comment.
I think EurekaClientIdentity may be a better name. We aren't doing any auth correct?
There was a problem hiding this comment.
That's a fair point. I actually had "client" in the name but later removed it because the auth also applies to server <-> server calls as well as client -> server.
How about just AbstractEurekaIdentify?
There was a problem hiding this comment.
typo, AbstractEurekaIdentity
|
eureka-pull-requests #154 FAILURE |
Adding filter to optionally log auth headers in eureka server.
|
eureka-pull-requests #155 SUCCESS |
Changing default config for server identity logging to true.
|
eureka-pull-requests #156 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding auth headers to eureka client and server outbound requests.
Adding filter to optionally log auth headers in eureka server.