Amend the check on IllegalAttachmentFileNameException #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhou2
force-pushed
the
dev-snapshot
branch
5 times, most recently
from
90c5e8e
to
8b4de07
Compare
zdong2
reviewed
May 3, 2024
.../src/main/java/com/netflix/genie/web/services/impl/LocalFileSystemAttachmentServiceImpl.java
Outdated
Show resolved
Hide resolved
bhou2
force-pushed
the
dev-snapshot
branch
2 times, most recently
from
c2ab465
to
7101d2d
Compare
bhou2
force-pushed
the
dev-snapshot
branch
2 times, most recently
from
ac667e5
to
f15d958
Compare
natedanner
pushed a commit
to natedanner/Netflix__genie
that referenced
this pull request
May 20, 2024
Co-authored-by: bhou <bhou@netflix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of checking the attachment filename is to avoid the filename to be . or .. or containing / or . So that users cannot put the attachments to any location via a hacking manner.