Minor documentation improvements #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprimi
commented
May 4, 2017
| @@ -20,7 +20,7 @@ then be accessed via Genie code if necessary. | |||
|
|
|||
| All the security can be enabled or disabled as desired by system administrators. You can find the various properties | |||
| under `genie.security.*` in the <<Properties>> section. Spring specific properties are also involved but the enabling | |||
| and disabling is done via the `genie.security` properties. | |||
| and disabling is done via the `security.*` properties. | |||
There was a problem hiding this comment.
I kinda guessed this by looking at https://netflix.github.io/genie/docs/3.0.5/reference/#_spring_properties
There was a problem hiding this comment.
You need to back this one out... enabling and disabling the current security profiles are done via the genie.security path.
There was a problem hiding this comment.
Done. I misread the paragraph the first time around.
|
@tgianos this is ready for review |
tgianos
changed the title
tgianos
suggested changes
May 8, 2017
| @@ -20,7 +20,7 @@ then be accessed via Genie code if necessary. | |||
|
|
|||
| All the security can be enabled or disabled as desired by system administrators. You can find the various properties | |||
| under `genie.security.*` in the <<Properties>> section. Spring specific properties are also involved but the enabling | |||
| and disabling is done via the `genie.security` properties. | |||
| and disabling is done via the `security.*` properties. | |||
There was a problem hiding this comment.
You need to back this one out... enabling and disabling the current security profiles are done via the genie.security path.
tgianos
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.