Fix role mapping in oauth2 authentication #4715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinmarva
requested review from
hosseinsh,
charhate,
jtschladen,
douglasc-nflx and
jmcrawford45
as code owners
charhate
requested changes
Dec 12, 2023
| if current_app.config.get("PING_INCLUDE_BEARER_TOKEN"): | ||
| if current_app.config.get("PING_INCLUDE_BEARER_TOKEN") and "ping" in current_app.config.get("ACTIVE_PROVIDERS"): | ||
| headers = {"Authorization": f"Bearer {access_token}"} | ||
| else: |
There was a problem hiding this comment.
If and else blocks are the same headers = {"Authorization": f"Bearer {access_token}"}, which seems incorrect. Not sure what code change you were going for. If you can correct it with the intended change.
There was a problem hiding this comment.
Sorry for the delay @charhate.
Apparently, the Authorization header is omitted in the PING provider when PING_INCLUDE_BEARER_TOKEN is False or is omitted.
But for the oauth2 provider, the Authorization header is mandatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging in with an oauth provider, the default roles (admin, operator and read-only) are not assigned.
The problem is that the roles are not obtained from the OAUTH2_USER_API_URL. They are obtained from the id_token.
It is mandatory to add the "Authorization" header of the oidc2 providers to obtain the user's information.