Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Add loader to artifact search bar #26

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

rsanteri
Copy link
Contributor

@rsanteri rsanteri commented Nov 5, 2021

Description of the Change

Add loader to artifact search input field.

@saikonen
Copy link
Collaborator

saikonen commented Nov 5, 2021

looks good. Just leaving a note in case an actual progress bar is also requested that the artifact search also provides progress info on the search process via

{
  "type": "progress",
  "fraction": number
}

where the number will be a fraction of (current idx)/(number of artifacts affected by searchterm)

For now I believe that a simple spinner is more than enough though.

@rsanteri rsanteri merged commit 01cf40e into master Nov 5, 2021
@rsanteri rsanteri deleted the fix/loader-to-artifact-search branch November 5, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants