-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for Review] fix bug where client can not access foreach stack #1766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comment to not introduce a new symbol.
metaflow/__init__.py
Outdated
@@ -143,6 +143,9 @@ class and related decorators. | |||
DataArtifact, | |||
) | |||
|
|||
# Data class needed for Client. | |||
from .tuple_util import ForeachFrame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, you probably don't need to import ForeachFrame. You can probably simply do: from . import tuple_util
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@darinyu -- is this no longer something you want merged? I thought it was still relevant. |
@darinyu for when you are back :) |
0cba69b
to
36eb274
Compare
Yeah this still needs to go in, it slipped during before my vacation. I just rebased this commit and I think it is ready to go in now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. I think we should be good to merge.
To reproduce, have a flow with foreach task, and then in python client, do
This is because this ForeachFrame is loaded to main, and defined in
task.py
. Without a flow, this ForeachFrame is not imported. This PR refactors the namedtuple util to top level (with minimum dependency) and import it at top level.