[cards] bug fix with error card renders #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
valayDave
commented
Jun 20, 2024
valayDave
commented
- Error cards didn't contain a reload token replacement because of which the UI keeps trying to poll for new cards.
- This is not the best situation because the UI will keep refreshing the card constantly until the UI catches hold of the card.
- The UI changes will obviously follow for situations where a data update might be published but a card doesn't end up getting saved because of some data store issue; This PR will fix the bug and ensures that if a error card gets created instead of an expected card then the UI still gets the right reload token.
- Error cards didn't contain a reload token replacement because of which the UI keeps trying to poll for new cards. - This is not the best situation because the UI will keep refreshing the card constantly until the UI catches hold of the card. - The UI changes will obviously follow for situations where a data update might be published but a card doesn't end up getting saved because of some data store issue; This PR will fix the bug and ensures that if a error card gets created instead of an expected card then the UI still gets the right reload token.
valayDave
force-pushed
the
valay/card-bug-fixes-001
branch
from
76c1ffc
to
cb5404b
Compare
savingoyal
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.