Bug/tr 46 fix pypi install #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UPDATE contributing - fix more formatting issues UPDATE contributing - fix more formatting issues UPDATE contributing - remove backticks from apparently fixed indenting
…o they would pip-compile to req.txt
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Pip installations. Should be working as intended now, from what I understand after completing this task, it appeared the problem you were mainly facing was a lack of MANIFEST.in file, which is required to tell Pypi which files to include. This problem may also be causing the issue with long_description, but as explained inline, I felt that solving this problem now would distract from the PR itself and muddy it a bit. So that should be kept separate. End of the day, Pip install now works. That's what it's all about.