This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Fix account join issue #1055
Merged
Fix account join issue #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced (partially) in Netflix#872. You can't filter on a table that hasn't been properly joined. Also, you can't join the same table several times, so the existing code would have also broken if account and accounttype were filtered at the same time. So, pull the join out, and invoke it when anyone needs it.
mikegrima
reviewed
May 2, 2018
| @@ -247,6 +248,7 @@ def get(self): | |||
| if 'active' in args: | |||
| active = args['active'].lower() == "true" | |||
| query = query.filter(ItemRevision.active == active) | |||
| join_accounts = True | |||
There was a problem hiding this comment.
This didn't previously have query = query.join((Account, Account.id == Item.account_id)). Is this supposed to be here also?
There was a problem hiding this comment.
Yes. The active filter not working properly is what caused me to notice this. I then fixed the other bugs I saw due to the same root issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced (partially) in #872. You can't filter on a table that hasn't
been properly joined.
This issue causes the
activefilter to return1/Nresults, whereNis the number of active accounts.Also, you can't join the same table several times, so the existing code
would have also broken if account and accounttype were filtered at the
same time.
So, pull the join out, and invoke it when anyone needs it.