Skip to content
This repository has been archived by the owner on Sep 17, 2021. It is now read-only.

Link ELB/ALB issues to related security groups where appropriate #859

Merged
merged 8 commits into from
Nov 8, 2017

Conversation

scriptsrc
Copy link
Contributor

@scriptsrc scriptsrc commented Nov 7, 2017

ELBs and ALBs should link to their security groups where appropriate.

This will allow ELBs/ALBs to show issues for Internet Accessible, Friendly Cross Account, Thirdparty Cross Account, and Unknown Access.

The UI dropdowns have been updated accordingly.

TODO:

  • Make tests pass
  • Test new methods
  • Update other elb/alb issues to use issue categories

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 71.411% when pulling fa9ad40 on elb_sg_checks_use_object_store into 16e1b37 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 71.47% when pulling 8cc0285 on elb_sg_checks_use_object_store into 16e1b37 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 71.458% when pulling a4f47c2 on elb_sg_checks_use_object_store into 16e1b37 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 71.458% when pulling a20d4d7 on elb_sg_checks_use_object_store into 16e1b37 on develop.

@scriptsrc scriptsrc merged commit 392dd9e into develop Nov 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants