Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Wait to send kill #134

Merged
merged 4 commits into from
Jun 6, 2018
Merged

Wait to send kill #134

merged 4 commits into from
Jun 6, 2018

Conversation

sargun
Copy link
Contributor

@sargun sargun commented May 30, 2018

No description provided.

@coveralls
Copy link

coveralls commented May 30, 2018

Pull Request Test Coverage Report for Build 1322

  • 57 of 81 (70.37%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 23.153%

Changes Missing Coverage Covered Lines Changed/Added Lines %
executor/mock/jobrunner.go 0 1 0.0%
executor/drivers/titusdriver.go 8 10 80.0%
executor/runner/runner.go 49 70 70.0%
Files with Coverage Reduction New Missed Lines %
executor/drivers/titusdriver.go 2 69.23%
executor/runner/runner.go 11 56.91%
Totals Coverage Status
Change from base Build 1318: 0.3%
Covered Lines: 2087
Relevant Lines: 9014

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 30, 2018

Codecov Report

Merging #134 into master will increase coverage by 0.14%.
The diff coverage is 72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   33.52%   33.67%   +0.14%     
==========================================
  Files          61       61              
  Lines        7094     7113      +19     
==========================================
+ Hits         2378     2395      +17     
+ Misses       4428     4427       -1     
- Partials      288      291       +3
Impacted Files Coverage Δ
executor/mock/jobrunner.go 76.36% <0%> (-0.11%) ⬇️
executor/drivers/titusdriver.go 84% <100%> (-3.5%) ⬇️
executor/runner/runner.go 63.63% <69.23%> (+1.4%) ⬆️
api/netflix/titus/agent.pb.go 27.86% <0%> (+0.24%) ⬆️

@@ -276,26 +313,26 @@ func (r *Runner) monitorContainer(ctx context.Context, startTime time.Time, stat
case statusMessage, ok := <-statusChan:
msg := statusMessage.Msg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably unrelated to changes here, but statusMessage can be nil here if statusChan was closed. We should probably move this to right after the if !ok check

@sargun sargun merged commit 44005d5 into master Jun 6, 2018
@sargun sargun deleted the wait-to-send-kill branch June 6, 2018 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants