This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1322
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 33.52% 33.67% +0.14%
==========================================
Files 61 61
Lines 7094 7113 +19
==========================================
+ Hits 2378 2395 +17
+ Misses 4428 4427 -1
- Partials 288 291 +3
|
fabiokung
approved these changes
Jun 6, 2018
executor/runner/runner.go
Outdated
@@ -276,26 +313,26 @@ func (r *Runner) monitorContainer(ctx context.Context, startTime time.Time, stat | |||
case statusMessage, ok := <-statusChan: | |||
msg := statusMessage.Msg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably unrelated to changes here, but statusMessage
can be nil here if statusChan
was closed. We should probably move this to right after the if !ok
check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.