Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Jumbo frame support #142

Merged
merged 3 commits into from
Jun 19, 2018
Merged

Jumbo frame support #142

merged 3 commits into from
Jun 19, 2018

Conversation

sargun
Copy link
Contributor

@sargun sargun commented Jun 15, 2018

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1378

  • 0 of 17 (0.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 23.104%

Changes Missing Coverage Covered Lines Changed/Added Lines %
vpc/setup/setup_linux.go 0 2 0.0%
vpc/allocate/setup_container.go 0 2 0.0%
executor/runtime/docker/docker.go 0 6 0.0%
vpc/allocate/setup_container_linux.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
executor/runtime/docker/docker.go 1 2.22%
Totals Coverage Status
Change from base Build 1372: -0.03%
Covered Lines: 2087
Relevant Lines: 9033

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #142 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   33.64%   33.59%   -0.05%     
==========================================
  Files          61       61              
  Lines        7118     7128      +10     
==========================================
  Hits         2395     2395              
- Misses       4432     4442      +10     
  Partials      291      291
Impacted Files Coverage Δ
executor/runtime/docker/docker.go 50.42% <0%> (-0.24%) ⬇️
vpc/setup/setup_linux.go 0% <0%> (ø) ⬆️
vpc/allocate/setup_container_linux.go 0% <0%> (ø) ⬆️
vpc/allocate/setup_container.go 0% <0%> (ø) ⬆️

Copy link
Contributor

@andrew-leung andrew-leung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a JIRA or other issue driving this change? Changes look good but I think I'm lacking some context for the change.

@sargun sargun merged commit 233448b into master Jun 19, 2018
@sargun sargun deleted the jumbo-frame-support branch June 19, 2018 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants