docker-runtime: Use single quotes in bash env file template

[cHYzZQo]

Using single quotes ensures that values are exported as literal values and not evaluated. Also escapes any single quotes in the value.

[coveralls]

Pull Request Test Coverage Report for Build 2137

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 24.532%

---

Totals
Change from base Build 2132:	0.02%
Covered Lines:	2436
Relevant Lines:	9930

---

💛 - Coveralls

[cHYzZQo]

Are tests expected to pass? I get the same lint failures on master. @sargun does master pass for you?

[sargun]

I know that linting has hit some issues temporarily. I think rob G. Will look at it when he’s back. What’s the urgency of the change?

…

Sent from my iPhone On Sep 14, 2018, at 23:02, cHYzZQo <notifications@github.com> wrote: Are tests expected to pass? I get the same lint failures on master. @sargun <https://github.com/sargun> does master pass for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#176 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAtyRN44ugmEH6tFdAiFCgxxsWdRlq1yks5ubJgMgaJpZM4WqNq2> .

[cHYzZQo]

Not urgent, just wanted to make sure it wasn't something i missing. Thanks

[codecov]

Codecov Report

Merging #176 into master will decrease coverage by 10.46%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #176       +/-   ##
===========================================
- Coverage   33.36%   22.89%   -10.47%     
===========================================
  Files          66       66               
  Lines        7876     7878        +2     
===========================================
- Hits         2628     1804      -824     
- Misses       4928     5861      +933     
+ Partials      320      213      -107

Impacted Files	Coverage Δ
executor/runtime/docker/docker.go	8.6% <100%> (-41.82%)	⬇️
executor/mock/jobrunner.go	0% <0%> (-75.53%)	⬇️
vpc/bpfloader/bpfloader_linux.go	0% <0%> (-64.11%)	⬇️
executor/runtime/docker/lxcfs.go	0% <0%> (-62.5%)	⬇️
executor/runtime/docker/docker_linux.go	0% <0%> (-52.84%)	⬇️
executor/runtime/types/types.go	43.18% <0%> (-36.37%)	⬇️
uploader/uploader.go	26.38% <0%> (-23.62%)	⬇️
executor/drivers/titusdriver.go	68% <0%> (-16%)	⬇️
filesystems/xattr/degrading_linux.go	75% <0%> (-14.29%)	⬇️
... and 8 more

[cHYzZQo]

Rebased now that the linting fixes are in.

[sargun]

@cHYzZQo Are you ready for review?

[cHYzZQo]

Yes

[sargun]

lgtm.

[sargun]

@cHYzZQo This looks good to me, but the one thing that might be valuable is to see is '$' is in the string, and fall back to the old behaviour. I don't think anyone is doing string interpolation, but might as well shield ourselves?

[cHYzZQo]

one thing that might be valuable is to see is '$' is in the string, and fall back to the old behaviour.

Is that really what we want? I don't think that would have ever worked well because 1) the initial environment wouldn't do any interpolation so it makes the initial environment that entrypoint is running under and the environment after bash -l inconsistent. 2) order isn't guaranteed so it's hard to reliably reference any other user defined variable.

But if you are sure you want it i'll add it in.

[sargun]

@cHYzZQo Makes sense. This looks good to me. @rgulewich do you want to take a look as well?

[rgulewich]

LGTM.