This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Add Docker config validation #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sargun
suggested changes
Oct 4, 2018
executor/runtime/docker/config.go
Outdated
| "time" | ||
| ) | ||
|
|
||
| const MinCfsBandwidth = 1000 |
There was a problem hiding this comment.
use const (
MinCfsBandwidth = 1000
MaxCfsBandwidth = 1000000
)
There was a problem hiding this comment.
actually, it appears these aren't used outside of this package. they should be locally scoped.
| package docker | ||
|
|
||
| import ( | ||
| "github.com/stretchr/testify/assert" |
| @@ -4,11 +4,11 @@ import ( | |||
| "bytes" | |||
| "context" | |||
| "errors" | |||
| "github.com/Netflix/titus-executor/properties" | |||
gabrielhartmann
force-pushed
the
cpuset
branch
from
685e273
to
a167dcd
Compare
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 21.62% 31.49% +9.87%
==========================================
Files 66 67 +1
Lines 8393 8397 +4
==========================================
+ Hits 1815 2645 +830
+ Misses 6365 5433 -932
- Partials 213 319 +106
|
Pull Request Test Coverage Report for Build 2212
💛 - Coveralls |
gabrielhartmann
force-pushed
the
cpuset
branch
from
a167dcd
to
a4c86d6
Compare
gabrielhartmann
force-pushed
the
cpuset
branch
from
a4c86d6
to
ddb8fb8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove fallback logic to nanos on violation of CFS bandwidth configuration. Fail fast instead. This change also moves code for configuration out of the large
docker.gofile.