Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance output of weep list #89

Merged
merged 6 commits into from
Sep 9, 2021
Merged

Enhance output of weep list #89

merged 6 commits into from
Sep 9, 2021

Conversation

jaydhulia
Copy link
Collaborator

@jaydhulia jaydhulia commented Sep 8, 2021

Depends on Netflix/consoleme#9230. Once the corresponding ConsoleMe PR is merged, this PR will be updated to call the v2 version of get_roles endpoint and include relevant data in the output.

By default, the command displays the following columns: Account name, Role name, Role ARN
If the flag -s / --short-info is used, then the command only outputs the columns: Role ARN
If the flag -e / --extended-info is used, then the command displays the following columns: Account name, Role name, Role ARN, App, App Owner. In the future, additional information can be added to display for this flag.

@jaydhulia jaydhulia changed the title [WIP] Enhance output of weep list Enhance output of weep list Sep 9, 2021
sb.WriteString(roles[i])
sb.WriteString("\n")
var headers []string
if shortInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty nifty. I like that we can use the same input data and change the output based on the headers we pass in. 👍

@jaydhulia jaydhulia merged commit 5ad4e63 into master Sep 9, 2021
@jaydhulia jaydhulia deleted the jdhulia-list-v2 branch September 9, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants