Implement Clique #34

tkstanczak · 2018-08-02T12:44:40Z

As you can see below - Gitcoin bounty has been funded for this issue (kudos to Gitcoin team).
Below you will find more information on what is expected:

Clique spec is available here:
ethereum/EIPs#225

Best place to seek help from the team is Gitter:
https://gitter.im/nethermindeth/nethermind

Write ISealEngine implementation representing Clique block sealing.
Write IBlockValidator / IBlockHeaderValidator to validate properly repurposed fields in BlockHeader
Make necessary changes to IChainSpecLoader to allow different seal engine to be loaded and change the Runner behaviour so the Clique seal engine and validators are loaded if chainspec declares them.
Create unit tests for ISealEngine implementation, unit tests for the new IBlockValidator / IBlockHeaderValidator.
Launch Nethermind and sync with Rinkeby test network (by providing a Rinkeby chainID).
Launch 4 nodes using RunnerSpawner to test a Clique based private network behaviour and proof that the ndoes can publish and validate nodes.
An implementation that is capable of (5) and (6) will be accepted. Core Nethermind team will be glad to provide all the help needed and introduce changes required to make code more consistent with the whole Nethermind codebase.

karalabe · 2018-08-06T08:22:28Z

Yes, Clique is production ready in Geth. Rinkeby was launched 480 days ago and it uses Clique. The code received almost no modifications since and has been working very nicely for us.

tkstanczak · 2018-09-18T09:30:31Z

ethereum/EIPs#225
https://gist.github.com/cryptogoth/10a98e8078cfd69f7ca892ddbdcf26bc

We assume that Clique is implemented in Nethermind (and PR accepted) if Nethermind can fully synchronize with Rinkeby network when using Rinkeby chainspec and pointing at Rinkeby bootnodes.

gitcoinbot · 2018-09-21T15:16:51Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 400.0 DAI (400.0 USD @ $1.0/DAI) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$23,854.17 more funded OSS Work available on the Gitcoin Issue Explorer

ChrisCates · 2018-09-24T11:59:21Z

Interested, will take a look at the source later today.
Will get back to you with questions tonight.

spm32 · 2018-09-25T18:05:17Z

Sounds good @ChrisCates keep us updated :)

gitcoinbot · 2018-09-26T20:43:06Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 months, 2 weeks ago.
Please review their action plans below:

1) destiner has been approved to start work.

Look up PoA specifics
Look at Geth implementation
Implement Clique PoA
Make unit tests
Test with Rinkeby
Test with local network

Learn more on the Gitcoin Issue Details page.

Destiner · 2018-09-26T20:43:55Z

Hi there. Want to dive into PoA, would love to work on this one :)

spm32 · 2018-09-26T20:56:46Z

Hey @Destiner great to hear, @ChrisCates were you still interested in following up on this issue? Want to give you a chance as you were the first one on it.

ChrisCates · 2018-09-26T22:01:24Z

@ceresstation, I don't want to hold up the project. A few things have came up on my end.
Since it is not the competition bounty type.

It's probably in your best interest to continue with @Destiner!

Thanks for being patient!

Destiner · 2018-09-29T12:03:30Z

Quick update.

I ran through Clique specs and implementation in go-ethereum, now working on setting up a dev environment.

tkstanczak · 2018-09-30T15:47:59Z

cool - join us on Gitter - you can always ask questions and get help with setting up dev

Destiner · 2018-10-02T09:41:51Z

I think I managed to build it, but can't run the node. Will try again and join gitter.

Destiner · 2018-10-05T19:49:18Z

I managed to write most of the code for validation and sealing. I'll try to get last touches on code (dealing with private keys as we discussed in gitter, etc), update ChainSpec, configs, etc to connect Clique with other parts of code, test internally and then hopefully make a few commits.

gitcoinbot · 2018-10-09T16:15:33Z

@Destiner Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2018-10-10T16:15:49Z

@Destiner Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Destiner · 2018-10-10T19:29:24Z

Working on Header Validator, try to submit a PR in a few days.

Destiner · 2018-10-12T23:10:55Z

Validation is done and working!

Will fix a few things, work on IDBProvider.GetOrCreate, wait until merge with spaceneth & then send PR.

gitcoinbot · 2018-10-21T16:15:22Z

@Destiner Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2018-10-22T16:15:28Z

@Destiner Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Destiner · 2018-10-22T19:36:29Z

@gitcoinbot yeah! Waiting for PR to be reviewed, and working on another PR.

Destiner · 2018-10-25T06:17:41Z

Added some unit tests and also made refactoring.

Planning to add more tests in a day or two.

gitcoinbot · 2018-10-28T16:15:18Z

@Destiner Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Destiner · 2018-10-29T05:08:26Z

Yep, working on it.

gitcoinbot · 2018-11-02T16:15:28Z

@Destiner Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot · 2018-11-03T16:15:17Z

@Destiner Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Destiner · 2018-11-03T18:24:36Z

Yep, working. Catched a bug in validation algo, will take time to fix it.

spm32 · 2018-11-05T19:34:41Z

Thanks for the update @Destiner!

…r field not copied when preparing blocks for processing)

spm32 · 2018-11-21T09:36:35Z

Hey @Destiner are you able to submit a WIP PR via Gitcoin? Thanks!

tkstanczak · 2018-11-22T00:17:04Z

Hi @gitcoinbot this can be marked as done and the reward can be paid out

gitcoinbot · 2018-11-22T05:14:58Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 400.0 DAI (400.0 USD @ $1.0/DAI) has been submitted by:

@destiner

@ceresstation please take a look at the submitted work:

(Link Not Provided) by @Destiner

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$38,256.37 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot · 2018-12-12T15:49:59Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 400.0 DAI (400.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @Destiner.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$45,693.32 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot · 2018-12-13T08:50:40Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 400.0 DAI (400.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @Destiner.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$45,504.28 more funded OSS Work available on the Gitcoin Issue Explorer

tkstanczak added the help wanted label Aug 2, 2018

tkstanczak added bounty Gitcoin bounty help wanted and removed help wanted labels Sep 21, 2018

tkstanczak added this to the Beta Release milestone Oct 2, 2018

Destiner mentioned this issue Oct 9, 2018

Add Rinkeby-related json files #166

Merged

Destiner mentioned this issue Oct 10, 2018

Add SpecProvider for Rinkeby #173

Merged

This was referenced Oct 16, 2018

Add header validation for Clique consensus #181

Merged

Bug fixes for Clique validation #185

Closed

Destiner mentioned this issue Oct 31, 2018

Unit tests for Snapshot #208

Merged

This was referenced Nov 4, 2018

Minor test fixes #212

Merged

Make Snapshot fields public for serialization #213

Merged

Implement sealing for Clique #214

Merged

Destiner mentioned this issue Nov 6, 2018

Fix old TODOs in Clique #216

Merged

tkstanczak added a commit that referenced this issue Nov 7, 2018

#34 fixed block 55 issue that was introduced after refactoring (autho…

b64beac

…r field not copied when preparing blocks for processing)

tkstanczak added a commit that referenced this issue Nov 7, 2018

#34 Rinkeby consensus fix around Coinbase (316658)

5966cff

tkstanczak closed this as completed Dec 15, 2018

flcl42 added a commit that referenced this issue Mar 19, 2024

Add RSA, ECDSA keys; CIDv1; add and fix tests (#34)

d80101e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Clique #34

Implement Clique #34

tkstanczak commented Aug 2, 2018 •

edited

Loading

karalabe commented Aug 6, 2018

tkstanczak commented Sep 18, 2018

gitcoinbot commented Sep 21, 2018

ChrisCates commented Sep 24, 2018

spm32 commented Sep 25, 2018

gitcoinbot commented Sep 26, 2018 •

edited

Loading

Destiner commented Sep 26, 2018

spm32 commented Sep 26, 2018

ChrisCates commented Sep 26, 2018

Destiner commented Sep 29, 2018

tkstanczak commented Sep 30, 2018

Destiner commented Oct 2, 2018

Destiner commented Oct 5, 2018

gitcoinbot commented Oct 9, 2018 •

edited by smartprogrammer93

Loading

gitcoinbot commented Oct 10, 2018

Destiner commented Oct 10, 2018

Destiner commented Oct 12, 2018

gitcoinbot commented Oct 21, 2018

gitcoinbot commented Oct 22, 2018

Destiner commented Oct 22, 2018

Destiner commented Oct 25, 2018

gitcoinbot commented Oct 28, 2018

Destiner commented Oct 29, 2018

gitcoinbot commented Nov 2, 2018

gitcoinbot commented Nov 3, 2018

Destiner commented Nov 3, 2018

spm32 commented Nov 5, 2018

spm32 commented Nov 21, 2018

tkstanczak commented Nov 22, 2018

gitcoinbot commented Nov 22, 2018

gitcoinbot commented Dec 12, 2018

gitcoinbot commented Dec 13, 2018

Implement Clique #34

Implement Clique #34

Comments

tkstanczak commented Aug 2, 2018 • edited Loading

karalabe commented Aug 6, 2018

tkstanczak commented Sep 18, 2018

gitcoinbot commented Sep 21, 2018

ChrisCates commented Sep 24, 2018

spm32 commented Sep 25, 2018

gitcoinbot commented Sep 26, 2018 • edited Loading

Destiner commented Sep 26, 2018

spm32 commented Sep 26, 2018

ChrisCates commented Sep 26, 2018

Destiner commented Sep 29, 2018

tkstanczak commented Sep 30, 2018

Destiner commented Oct 2, 2018

Destiner commented Oct 5, 2018

gitcoinbot commented Oct 9, 2018 • edited by smartprogrammer93 Loading

gitcoinbot commented Oct 10, 2018

Destiner commented Oct 10, 2018

Destiner commented Oct 12, 2018

gitcoinbot commented Oct 21, 2018

gitcoinbot commented Oct 22, 2018

Destiner commented Oct 22, 2018

Destiner commented Oct 25, 2018

gitcoinbot commented Oct 28, 2018

Destiner commented Oct 29, 2018

gitcoinbot commented Nov 2, 2018

gitcoinbot commented Nov 3, 2018

Destiner commented Nov 3, 2018

spm32 commented Nov 5, 2018

spm32 commented Nov 21, 2018

tkstanczak commented Nov 22, 2018

gitcoinbot commented Nov 22, 2018

gitcoinbot commented Dec 12, 2018

gitcoinbot commented Dec 13, 2018

tkstanczak commented Aug 2, 2018 •

edited

Loading

gitcoinbot commented Sep 26, 2018 •

edited

Loading

gitcoinbot commented Oct 9, 2018 •

edited by smartprogrammer93

Loading