Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile if statement #4076

Merged
merged 1 commit into from
May 28, 2022
Merged

Fix Dockerfile if statement #4076

merged 1 commit into from
May 28, 2022

Conversation

FalcoXYZ
Copy link
Contributor

Fixes

Changes:

Fixes the if statement in the Dockerfile to correct amd64 not building.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

I've tested this on the following architectures + ubuntu verisons:

PRETTY_NAME="**Ubuntu 20.04.4** LTS"
Linux localhost 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 **x86_64 x86_64 x86_64** GNU/Linux

PRETTY_NAME="**Ubuntu 22.04** LTS"
Linux localhost 5.15.0-27-generic #28-Ubuntu SMP Thu Apr 14 04:55:28 UTC 2022 **x86_64 x86_64 x86_64** GNU/Linux

PRETTY_NAME="**Ubuntu 20.04.4** LTS"
Linux 5.13.0-1022-aws #24~20.04.1-Ubuntu SMP Thu Apr 7 22:14:11 UTC 2022 **aarch64 aarch64 aarch64** GNU/Linux

PRETTY_NAME="**Ubuntu 22.04** LTS"
Linux 5.15.0-1004-aws #6-Ubuntu SMP Thu Mar 31 09:49:20 UTC 2022 **aarch64 aarch64 aarch64** GNU/Linux

All builds succeeded without errors, containers boot up and started syncing + connected to peers. Restarting the container also worked and didn't show any errors. @AntiD2ta can you test this once more to make sure it works before we merge this? Or maybe you can run the pipeline on my branch to verify it works properly?

@FalcoXYZ FalcoXYZ requested a review from AntiD2ta May 28, 2022 09:11
@AntiD2ta AntiD2ta marked this pull request as ready for review May 28, 2022 14:48
@AntiD2ta AntiD2ta merged commit 0b1d414 into master May 28, 2022
@AntiD2ta AntiD2ta deleted the dockerfile-fix branch May 28, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants