Reject pre-pivot payloads #4216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
Jun 28, 2022
|
|
||
| if (block.Header.Number <= _syncConfig.PivotNumberParsed) | ||
| { | ||
| if (_logger.IsTrace) _logger.Trace($"Pre-pivot block, ignored and returned Syncing. Result of {requestStr}."); |
There was a problem hiding this comment.
hmmm maybe trace -> info ?
There was a problem hiding this comment.
@marcindsobczak it would be good to a simple unit test
MarekM25
approved these changes
Jun 28, 2022
|
Closing in favor of #4224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
syncingwhen received payload is pre-pivotThis PR is fixing issue with not downloading old blocks if pivot is post-merge
Types of changes
Testing
Requires testing
In case you checked yes, did you write tests??