EIP-3860 Max init code size limit and extra gas charge #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demuirgos
reviewed
Oct 11, 2022
LukaszRozmej
approved these changes
Oct 25, 2022
| @@ -57,6 +57,11 @@ private static long DataCost(Transaction transaction, IReleaseSpec releaseSpec) | |||
| } | |||
| } | |||
|
|
|||
| if (transaction.IsContractCreation && releaseSpec.IsEip3860Enabled) | |||
| { | |||
| dataCost += EvmPooledMemory.Div32Ceiling((ulong)transaction.Data.Length) * GasCostOf.InitCodeWord; | |||
There was a problem hiding this comment.
why ulong cast and not directly to UInt256?
There was a problem hiding this comment.
In all the occurances I found when Div32Ceiling was called for an int parameter, it was cast to ulong.
There was a problem hiding this comment.
Please cast directly to UInt256, we can change those old ones to do the same.
Dunno why was cast to ulong, it was BigInteger before:
And merge it after.
MarekM25
reviewed
Oct 28, 2022
MarekM25
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4588
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Further comments (optional)
Implements EIP-3860 which is still draft.