Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate EngineCapabilities into HealthChecks #5244

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Integrate EngineCapabilities into HealthChecks #5244

merged 5 commits into from
Feb 7, 2023

Conversation

deffrian
Copy link
Contributor

@deffrian deffrian commented Feb 6, 2023 •
edited
Loading

Fixes Closes Resolves #

#5185

Changes

  • New interface IRpcCapabilitiesProvider
  • Both HealthChecks plugin and ExchangeCapabilities access capabilities through this interface

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@deffrian deffrian linked an issue Feb 6, 2023 that may be closed by this pull request
No incoming messages from Consensus Client - bug #5185
Closed
@deffrian deffrian marked this pull request as ready for review February 7, 2023 10:00
MarekM25
MarekM25 reviewed Feb 7, 2023
View reviewed changes
src/Nethermind/Nethermind.HealthChecks/NodeHealthService.cs Outdated
{
if (capability.Value)
{
result |= CheckMethodInvoked(capability.Key, now);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if true we could break the loop

@deffrian deffrian merged commit 8e61bf9 into master Feb 7, 2023
@deffrian deffrian deleted the fix/5185-no-incoming-messages-from-consensus-client-bug branch February 7, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-orzechowski damian-orzechowski damian-orzechowski left review comments

@MarekM25 MarekM25 MarekM25 approved these changes

@rubo rubo Awaiting requested review from rubo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No incoming messages from Consensus Client - bug
3 participants
@deffrian @MarekM25 @damian-orzechowski