FixTotalDifficulty db migration #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
requested changes
Mar 16, 2023
This reverts commit 312a3e1.
|
And update about this PR ? Will this PR be merged ? |
|
@abcfy2 Most probably will be merged next week. After that we can make custom docker image for you. Or you can wait until next release |
|
Thanks. But I use Ubuntu ppa for deployment. So I have to wait for next release. Thanks all the same. |
| private void RunMigration(long startingBlock, long? lastBlock, CancellationToken cancellationToken) | ||
| { | ||
| IChainLevelInfoRepository chainLevelInfoRepository = _api.ChainLevelInfoRepository ?? throw new ArgumentNullException(nameof(_api.ChainLevelInfoRepository)); | ||
| IBlockTree blockTree = _api.BlockTree ?? throw new ArgumentNullException(nameof(_api.BlockTree)); |
There was a problem hiding this comment.
If migration is only using BlockTree and ChainLevelInfoHistory, it could accept these interfaces in constructor and perform argument check earlier.
|
|
||
| UInt256 expectedTd = previousTd + header.Difficulty; | ||
| ChainLevelInfo currentLevel = chainLevelInfoRepository.LoadLevel(blockNumber)!; | ||
| UInt256 actualTd = currentLevel.BlockInfos[0].TotalDifficulty; |
There was a problem hiding this comment.
Just a question - is this possible to have different TD in block info at any other index?
MarekM25
approved these changes
Apr 12, 2023
deffrian
deleted the
5341-trace_block-error-systeminvalidoperationexception-block-without-total-difficulty-calculated-was-suggested-for-processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
#5341
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing