Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a couple additional ArrayPoolLists #5599

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Return a couple additional ArrayPoolLists #5599

merged 1 commit into from
Apr 23, 2023

Conversation

benaadams
Copy link
Member

Very minor

Changes

  • Dispose two additional ArrayPoolLists
  • Refactor existing ones to use using
  • Use ArrayPool<T>.Shared directly rather than storing in field (Jit can then devirtualise)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams added the bug label Apr 22, 2023
@benaadams benaadams requested a review from asdacap April 22, 2023 03:26
Copy link
Contributor

@asdacap asdacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benaadams benaadams merged commit 62d2aa3 into master Apr 23, 2023
@benaadams benaadams deleted the ArrayPool branch April 23, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants