Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NUnit Analyzers #5638

Merged
merged 3 commits into from
May 2, 2023
Merged

Add NUnit Analyzers #5638

merged 3 commits into from
May 2, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented May 2, 2023

Changes

  • Added NUnit Analyzers as recommended by the NUnit team. Assertions have been updated by analyzers automatically, and a few of them have been revised manually. For instance:

    -Assert.AreEqual(expected, actual);
    +Assert.That(actual, Is.EqualTo(expected));
  • All test projects referencing NUnit package now reference NUnit.Analyzers package as well

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Remarks

The analyzers have already caught a few issues and fixed them.

@LukaszRozmej
Copy link
Member

I still prefer FluentAssertions :)

@rubo rubo merged commit 50b95ee into master May 2, 2023
@rubo rubo deleted the feature/nunit-analyzers branch May 2, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants