Add config for eth_getLogs max block depth #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdacap
changed the title
LukaszRozmej
approved these changes
May 4, 2023
LukaszRozmej
reviewed
May 4, 2023
| @@ -21,4 +21,7 @@ public interface IReceiptConfig : IConfig | |||
|
|
|||
| [ConfigItem(Description = "Number of recent blocks to maintain transaction index. 0 to never remove tx index. -1 to never index.", DefaultValue = "2350000")] | |||
| long? TxLookupLimit { get; set; } | |||
|
|
|||
| [ConfigItem(Description = "Max num of block per eth_getLogs request.", DefaultValue = "10000")] | |||
There was a problem hiding this comment.
As it doesn't matter with Bloom Index (which is default), maybe we should hide it from docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Remarks
Optional. Remove if not applicable.