Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KeccaksIterator not working when some keccak zero prefix is not i… #5780

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Fix KeccaksIterator not working when some keccak zero prefix is not i… #5780

merged 5 commits into from
Jun 6, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jun 6, 2023 •
edited
Loading

  • Fix keccaks iterator not correctly detect more items when other item is zero prefixed.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

@benaadams benaadams added the bug label Jun 6, 2023
@MarekM25 MarekM25 self-requested a review June 6, 2023 10:56
@asdacap asdacap merged commit 8667000 into master Jun 6, 2023
@asdacap asdacap deleted the fix/missing-eth-getlogs branch June 6, 2023 11:00
kamilchodola pushed a commit that referenced this pull request Jun 6, 2023
@asdacap @kamilchodola
Fix KeccaksIterator not working when some keccak zero prefix is not i… (
6fa1393 
#5780)

* Fix KeccaksIterator not working when some keccak zero prefix is not included.

* Fix whitespace

* Fix reset

* More tests

* One more scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asdacap @MarekM25 @LukaszRozmej @benaadams