Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/feed DNS to discv4 #6035

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Feature/feed DNS to discv4 #6035

merged 4 commits into from
Sep 5, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Aug 24, 2023 •
edited

  • On goerli, all the bootnodes does not response for some reason.
  • To compensate for that, this adds a code that feeds nodes from DNS discovery to disv4 to somewhat seed it.
  • Unlike with disv4, entry from dns may be offline (disv4 wait for Pong message).
  • This seems to cause some noise, so it limit the number of added record to 50. The amount does not strictly matter much, it just need one node that can respond.

Changes

  • Seed discv4 with dns.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

@asdacap asdacap changed the title Feature/feed enrdns to discv4 Feature/feed DNS to discv4 Aug 24, 2023
@asdacap asdacap marked this pull request as ready for review August 24, 2023 13:44
This was referenced Aug 28, 2023
Closed
Merged
@asdacap asdacap merged commit 0604348 into master Sep 5, 2023
61 checks passed
@asdacap asdacap deleted the feature/feed-enrdns-to-discv4 branch September 5, 2023 04:31
kamilchodola pushed a commit that referenced this pull request Nov 19, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
5322e20 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
kamilchodola pushed a commit that referenced this pull request Nov 20, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
d52100c 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
kamilchodola pushed a commit that referenced this pull request Nov 20, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
13eee6a 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
kamilchodola pushed a commit that referenced this pull request Nov 20, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
57e585f 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
kamilchodola pushed a commit that referenced this pull request Nov 21, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
7b26642 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
kamilchodola pushed a commit that referenced this pull request Nov 21, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
c74ab5a 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
kamilchodola pushed a commit that referenced this pull request Nov 22, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
d366c4b 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
kamilchodola pushed a commit that referenced this pull request Nov 22, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
3b5e6b0 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
kamilchodola pushed a commit that referenced this pull request Nov 23, 2023
@asdacap @kamilchodola
Feature/feed DNS to discv4 (#6035)
3c2f38c 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
brbrr pushed a commit that referenced this pull request Jan 16, 2024
@asdacap @brbrr
Feature/feed DNS to discv4 (#6035)
8856fcd 
* Feed ENR dns to discovery appp

* Missed a file

* Unit tests

* Fixed misconfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flcl42 flcl42 flcl42 left review comments

@kamilchodola kamilchodola kamilchodola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asdacap @flcl42 @kamilchodola