Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont stop peer connection on any exception #6038

Merged
merged 8 commits into from
Sep 4, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Aug 25, 2023

Addresses #6014

  • On one of the log @kamilchodola gave, the peer loop exited very early without any exception. mistake in task handling causes it to not wait for worker thread exit, but not a problem.
  • There is a mistake in the tasks handling which hide the exception probably.
  • This fixes it and make sure it does not stop trying on exception.
  • Discovery thread does not seems to start after initial bootnodes connection.
  • Seems like task scheduler from dotnetty, maybe hanging.
  • Switching to explicitly running default task scheduler.

Changes

  • Fix connection loop exception accidentally hidden.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Well, nothing bad happened for sure.

@asdacap
Copy link
Contributor Author

asdacap commented Aug 29, 2023

Made a mistake with my personal log cleaner causing me to miss some important log. Everything seems to be working as expected except for not getting new nodes from bootnodes. @kamilchodola is verifying that #6035 fix the issue.

@asdacap asdacap closed this Aug 29, 2023
@asdacap
Copy link
Contributor Author

asdacap commented Aug 30, 2023

Turns out #6035 does not fix the problem.

@asdacap asdacap reopened this Aug 30, 2023
@asdacap asdacap marked this pull request as ready for review August 31, 2023 08:38
@asdacap asdacap merged commit 54b207f into master Sep 4, 2023
61 checks passed
@asdacap asdacap deleted the fix/dont-stop-peer-connection-on-exception branch September 4, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants