Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially validate block with unknown parent #6085

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Partially validate block with unknown parent #6085

merged 4 commits into from
Sep 19, 2023

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Sep 8, 2023

Changes

  • Validate what we can in case of no parent

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 requested a review from MarekM25 September 8, 2023 16:33
@flcl42 flcl42 marked this pull request as ready for review September 11, 2023 08:47
@flcl42 flcl42 merged commit 24445a5 into master Sep 19, 2023
61 checks passed
@flcl42 flcl42 deleted the hotfix/more-validate-on-beacon-sync branch September 19, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@marcindsobczak marcindsobczak marcindsobczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flcl42 @MarekM25 @LukaszRozmej @marcindsobczak