Set head according to fcuState even when attributes are incorrect

[flcl42]

Fixes Closes Resolves hive test

Changes

• Sets head according to fcuState even when attributes are incorrect

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

[flcl42]

This is the main change:

• run ApplyForkchoiceUpdate,
• only then validate params and fork, return error if found,
• or error from ApplyForkchoiceUpdate
• or anything else returned by StartBuildingPayload

@jflo @MarekM25

[LukaszRozmej]

This looks wrong to me; the wrong version is called and we are doing everything and only returning an error at the end. Sounds wrong. Did you consider that the hive test is poorly constructed and should be amended? Did you discuss it with Hive test guys? Did you discuss it as spec?

[flcl42]

This looks wrong to me; the wrong version is called and we are doing everything and only returning an error at the end. Sounds wrong.

Wrong version of what? It returns result if presents, result can be an error or SYNCING/VALID, not just error. Let's call?

Did you consider that the hive test is poorly constructed and should be amended? Did you discuss it with Hive test guys? Did you discuss it as spec?

Yes, sure, it was not obvious for me too

[LukaszRozmej]

I hate the spec and would like to change it, but the PR looks good