Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EIP-4844 chain spec parameters #6205

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Rename EIP-4844 chain spec parameters #6205

merged 1 commit into from
Oct 19, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Oct 18, 2023 •
edited
Loading

Changes

Prefixed EIP-4844 chain spec parameters with eip4844 to keep them more discoverable and sorted together.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@rubo rubo merged commit 2290133 into master Oct 19, 2023
61 checks passed
@rubo rubo deleted the feature/eip-4844-chain-spec branch October 19, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@flcl42 flcl42 Awaiting requested review from flcl42

Assignees
No one assigned
Labels
configuration eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubo @LukaszRozmej