Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented eth_getBlockReceipts #6281

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Implemented eth_getBlockReceipts #6281

merged 4 commits into from
Nov 25, 2023

Conversation

Marchhill
Copy link
Contributor

@Marchhill Marchhill commented Nov 21, 2023 •
edited

Resolves #5944

Changes

  • Implemented eth_getBlockReceipts by reusing implementation of parity_getBlockReceipts

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Please check that the test case and expected result is reasonable

Documentation

Requires documentation update

  • Yes
  • No

Will happen automatically

Requires explanation in Release Notes

  • Yes
  • No

@MarekM25 MarekM25 marked this pull request as ready for review November 25, 2023 17:30
@MarekM25 MarekM25 merged commit 43d05b8 into master Nov 25, 2023
62 checks passed
@MarekM25 MarekM25 deleted the feature/eth_getBlockReceipts branch November 25, 2023 17:31
@smartprogrammer93 smartprogrammer93 mentioned this pull request Dec 8, 2023
Closed
16 tasks
gr8h pushed a commit to fuseio/nethermind-client that referenced this pull request Dec 12, 2023
@Marchhill @gr8h
Implemented eth_getBlockReceipts (NethermindEth#6281)
d2cb7eb 
* added eth_getBlockReceipts

* return null when block not found

* fixed test and example response

* fix benchmarks

---------

Co-authored-by: Marc Harvey-Hill <marc@Marcs-MacBook-Pro.local>
Co-authored-by: Marc Harvey-Hill <marc@dhcp-10-249-183-7.eduroam.wireless.private.cam.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement eth_getBlockReceipts
2 participants
@Marchhill @MarekM25