Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eth_getBlockReceipts and corresponding tests #6049

Closed
wants to merge 1 commit into from
Closed

Add eth_getBlockReceipts and corresponding tests #6049

wants to merge 1 commit into from

Conversation

nzmpi
Copy link

@nzmpi nzmpi commented Aug 29, 2023

Fixes #5944

Changes

  • Add eth_getBlockReceipts
  • Add Eth_get_block_receipts_by_number and Eth_get_block_receipts_by_hash tests

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about reusing RPC method from ParityRpcModule

@protolambda
Copy link

@MarekM25 Can this PR be reconsidered? The RPC method is standardized in ethereum/execution-apis#438 and Geth supports it too: ethereum/go-ethereum#27702

@smartprogrammer93
Copy link
Contributor

Closed as implemented by #6281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement eth_getBlockReceipts
4 participants