Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancun spec and config for mainnet #6679

Merged
merged 4 commits into from Feb 13, 2024

Conversation

smartprogrammer93
Copy link
Contributor

Changes

  • Cancun spec and config for mainnet

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

Cancun spec and config for mainnet added

@smartprogrammer93
Copy link
Contributor Author

@marcindsobczak what do you think about luk's comments?

@marcindsobczak
Copy link
Contributor

Agree with @LukaszRozmej , we have 2048 as default TxPool size for many years and it works well (we tested 1k, 4k and 8k back then and chose 2k), no need to change it now (especially without benchmarking).

About making StorageWithReorgs default - agree as well.
If you @smartprogrammer93 want you can change default value and then adjust every pre-canun config to

  "TxPool": {
    "BlobsSupport": "Disabled"
  },

But if you want, we can merge it as it is (except 1024 for std TxPool) and I will handle it in separate PR

@smartprogrammer93
Copy link
Contributor Author

@marcindsobczak ill address it in this PR. No problem

@rubo
Copy link
Contributor

rubo commented Feb 12, 2024

Given the TxPool.Size: 1024 for Chiado, don't we need the same for Gnosis?

@smartprogrammer93
Copy link
Contributor Author

@rubo i think the idea is testnets usually run on lower spec machines. and that is why we have 1024 for testnets and 2048 for "mainnets"

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukaszRozmej LukaszRozmej merged commit d1575b2 into master Feb 13, 2024
67 checks passed
@LukaszRozmej LukaszRozmej deleted the feature/cancun-spec-and-config-for-mainnet branch February 13, 2024 13:40
kamilchodola added a commit that referenced this pull request Feb 16, 2024
* Resolved conflicts

* max body size for http json rpc (#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (#6672)

* Update txPool worst value if removal unsuccessful (#6702)

* Add Cancun hard-fork settings for Gnosis (#6709)

* Cancun spec and config for mainnet (#6679)

* Add Paris release spec class for completeness (#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
kamilchodola added a commit that referenced this pull request Feb 23, 2024
* Resolved conflicts

* max body size for http json rpc (#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (#6672)

* Update txPool worst value if removal unsuccessful (#6702)

* Add Cancun hard-fork settings for Gnosis (#6709)

* Cancun spec and config for mainnet (#6679)

* Add Paris release spec class for completeness (#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
kamilchodola added a commit that referenced this pull request Feb 26, 2024
* Resolved conflicts

* max body size for http json rpc (#36)

* Format

* Self-recovery of TxPool max capacity

* fix ProcessedTransactionsDbCleanerTests

* Update txPool worst value if removal unsuccessful (#6702)

(cherry picked from commit f262cb2)

* Clearer error message for missing starting block state (#6672)

* Update txPool worst value if removal unsuccessful (#6702)

* Add Cancun hard-fork settings for Gnosis (#6709)

* Cancun spec and config for mainnet (#6679)

* Add Paris release spec class for completeness (#6633)

* 0.0.0.0 to +

---------

Co-authored-by: smartprogrammer <smartprogrammer@windowslive.com>
Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Kamil Chodoła <kamil@nethermind.io>
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants