Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review feedback for cmake-debugging #1

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Code review feedback for cmake-debugging #1

merged 2 commits into from
Aug 29, 2023

Conversation

BillyONeal
Copy link

  • Make multiple uses of the new switches an error
  • Deduplicate the logic of "no entries means no filter, one or more entries means port filter"
  • Add unit test

@BillyONeal
* Make multiple uses of the new switches an error
7dcd792 
* Deduplicate the logic of "no entries means no filter, one or more entries means port filter"
* Add unit test
@BillyONeal
clang-format
7189509
@BillyONeal BillyONeal mentioned this pull request Aug 29, 2023
Merged
@Neumann-A Neumann-A merged commit cf63f08 into Neumann-A:cmake_debugging Aug 29, 2023
@BillyONeal BillyONeal deleted the cmake_debugging branch August 29, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyONeal @Neumann-A