Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition of a "Required" property as defined in the schema. #395

Closed
lawrence-mbf opened this issue Feb 16, 2022 · 0 comments · Fixed by #397
Closed

Fix definition of a "Required" property as defined in the schema. #395

lawrence-mbf opened this issue Feb 16, 2022 · 0 comments · Fixed by #397
Assignees

Comments

@lawrence-mbf
Copy link
Collaborator

Currently, "required" properties error if the field is empty. However, the schema defines "required" properties as the existence of the field in the file itself.

MatNWB should instead use this method:
If the property is "required": The data should be written regardless of its contents.
If the property is "optional": The data should be written only if not empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant