-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subject age timedelta #1590
Subject age timedelta #1590
Conversation
Also added test for this
Codecov Report
@@ Coverage Diff @@
## dev #1590 +/- ##
=======================================
Coverage 91.30% 91.31%
=======================================
Files 25 25
Lines 2508 2510 +2
Branches 471 472 +1
=======================================
+ Hits 2290 2292 +2
Misses 138 138
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I hesitate to |
PyNWB requires
from pandas import Timedelta
time_delta = Timedelta(days=2,weeks=1, minutes=50, seconds=12)
iso_string = time_delta.isoformat() so all you would have to do to accommodate both that class type and |
And actually, as far as I can tell, import datetime
import pandas
time_delta = pandas.Timedelta(datetime.timedelta(days=2,weeks=1, minutes=50, seconds=12))
iso_string = time_delta.isoformat() |
I think this is a pretty simple function and I'm pretty confident it's going to work but I'd also be fine with using pandas |
Looks good to me. Thanks! |
Motivation
fix #1554
How to test the behavior?
Checklist
flake8
from the source directory.