Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numba jit speed increase #57

Open
ccluri opened this issue Oct 25, 2018 · 5 comments
Open

numba jit speed increase #57

ccluri opened this issue Oct 25, 2018 · 5 comments
Assignees

Comments

@ccluri
Copy link
Collaborator

ccluri commented Oct 25, 2018

If we add numba as a requirement instead of skmonaco, we can then then deploy with just-in-time compiler
https://numba.pydata.org/numba-doc/dev/user/5minguide.html
Adding this line above all functions in basis_functions.py and before forward_method() and int_pot1d() / 2d() / 3d() in KCSD.py

@jit(nopython=True)

already improves the performance drastically, I am able to knock off ~7 secs from a 30 sec tests.

@ccluri
Copy link
Collaborator Author

ccluri commented Oct 25, 2018

@asiaszmek what do you think?

@asiaszmek
Copy link
Collaborator

asiaszmek commented Oct 25, 2018 via email

@ccluri
Copy link
Collaborator Author

ccluri commented Oct 25, 2018

Hah! This was your idea though! :) 👍
I was just playing with numba instead of cython

@ccluri
Copy link
Collaborator Author

ccluri commented Nov 11, 2018

An attempt on this lives on saved_tables branch

from numba import jit

and in
from numba import jit

Do not merge with master, before #64 is addressed.

@ccluri ccluri assigned ccluri and asiaszmek and unassigned ccluri Nov 11, 2018
@ccluri ccluri mentioned this issue Nov 23, 2018
@ccluri
Copy link
Collaborator Author

ccluri commented Nov 23, 2018

Separating the co-dependence on #64 , an the PR #69 address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants