-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numba jit speed increase #57
Labels
Comments
@asiaszmek what do you think? |
I think it's a great idea. I'll start working on that once I am done with the build.
…On Thu, Oct 25, 2018 at 03:29:26PM +0000, Chaitanya Chintaluri wrote:
@asiaszmek what do you think?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#57 (comment)
|
Hah! This was your idea though! :) 👍 |
An attempt on this lives on saved_tables branch Line 15 in 7dc8bfe
and in kCSD-python/kcsd/basis_functions.py Line 16 in 7dc8bfe
Do not merge with master, before #64 is addressed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we add numba as a requirement instead of skmonaco, we can then then deploy with just-in-time compiler
https://numba.pydata.org/numba-doc/dev/user/5minguide.html
Adding this line above all functions in basis_functions.py and before forward_method() and int_pot1d() / 2d() / 3d() in KCSD.py
@jit(nopython=True)
already improves the performance drastically, I am able to knock off ~7 secs from a 30 sec tests.
The text was updated successfully, but these errors were encountered: