Fix windows unicode error #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kcsd.validation.csd_profile.gauss_2d_large(seed=63)` does not return NaN anymore. `repeatUntilValid()` decorator has been defined for that purpose. A simple test for the fix provided in the `__main__` section of the module. Note: The issue has not been solved by fixing distribution of the `zs` variable in order to provide backward-compatibility.
…on.csd_profile.repeatUntilValid()` decorator.
…ely) neverending loop of seeds.
Seed sequence generation moved to `seedSequence()` generator function.
…e has changed though).
According to https://docs.python.org/3/library/builtins.html imports from `builtsin` are unnecessary. As `builtsin` is Python 3 only, their removal increases beckward-compatibility of the package. Fixes Neuroinflab#77
Upstream = Neuroinflab/kCSD-python
I have included code which generates figure with EPMs (Fig. 7 at the moment). Also, `colorblind_friendly` module with definition of colorblind friendly colors is provided, which my code depends on.
Conflicts: figures/kCSD_properties/error_propagation.py
It seems that encoding of text files at Windows systems may default to legacy encodings (like cp1252), thus the utf-8 encoding of the README.rst is now given explicitely.
|
Bad master branch, sorry. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ccluri that fix should fix the
UnicodeDecodeErrorissue when installing on Windows systems