Feature/98 은행 하드코딩, 은행 선택, 미선택 UI #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangbaam
reviewed
Feb 13, 2024
Comment on lines
+428
to
435
| BankInfo.entries.forEach { bankInfo -> | ||
| item { | ||
| BackItem() | ||
| BackItem( | ||
| bankInfo = bankInfo, | ||
| onClick = {}, | ||
| selected = bankInfo.code == "003" | ||
| ) | ||
| } |
There was a problem hiding this comment.
그거 물어봤는데, 서버에서 아이콘을 주지는 않아서 하드 코딩으로 넣었어!
There was a problem hiding this comment.
code 를 key 로 해서 서버에서 내려주는 순서에 의존하는건 어때?
There was a problem hiding this comment.
enum class는 그대로 두고, 서버에서 준 code 기준으로 정렬해서 보여주자는 뜻인가??
|
일단 이 부분은 서버에서도 코드 순서대로 내려주고 있긴 해서, 순서에 대한 논의가 필요할 듯! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내용
코멘트