Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main, recruitment): fix before_recruitment, is_recruiting #24

Merged
merged 2 commits into from
Apr 23, 2023
Merged

fix(main, recruitment): fix before_recruitment, is_recruiting #24

merged 2 commits into from
Apr 23, 2023

Conversation

emost22
Copy link
Member

@emost22 emost22 commented Apr 23, 2023 •
edited
Loading

Summary

모집 공지, 시작 기간에 배너 및 header가 바로 바뀌도록 수정
image

Issue

@emost22 emost22 added the bug Something isn't working label Apr 23, 2023
@emost22 emost22 requested a review from CODe5753 April 23, 2023 15:34
@emost22 emost22 self-assigned this Apr 23, 2023
@CODe5753
Copy link
Member

https://github.com/Nexters/teamnexters.com/blob/main/CHANGELOG.md
65aafab

위 내용과 커밋 컨벤션 참고하여 커밋 title 변경 부탁드립니다.

@CODe5753 CODe5753 changed the title fix(main&recruitment): fix before_recruitment, is_recruiting fix(main, recruitment): fix before_recruitment, is_recruiting Apr 23, 2023
@emost22
Copy link
Member Author

emost22 commented Apr 23, 2023

@CODe5753
변경 완료했습니다

CODe5753
CODe5753 reviewed Apr 23, 2023
View reviewed changes
layouts/recruitment.vue Outdated Show resolved Hide resolved
@emost22 emost22 removed the no merge label Apr 23, 2023
@emost22 emost22 requested a review from CODe5753 April 23, 2023 16:34
CODe5753
CODe5753 approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@CODe5753 CODe5753 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상세한 설명 감사합니다.
고생하셨습니다.

@emost22 emost22 merged commit 10e873d into Nexters:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CODe5753 CODe5753 CODe5753 approved these changes

@mcauto mcauto Awaiting requested review from mcauto mcauto is a code owner

@KimHunJin KimHunJin Awaiting requested review from KimHunJin KimHunJin is a code owner

Assignees

@emost22 emost22

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

모집 공지, 시작 기간에 banner, header가 바뀌지 않는 문제
2 participants
@emost22 @CODe5753