Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03-pages > 01-building-your-application > 08-upgrading > 05-version-11.mdx #377

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

prayinforrain
Copy link
Contributor

@prayinforrain prayinforrain commented Jul 1, 2023

close #297

  • Webpack을 영단어 그대로 적었습니다. React와 Next.js를 그대로 적는 것과 같은 맥락이라고 생각했습니다. 대소문자는 원문의 것을 그대로 옮겼습니다.
  • import라는 표현을 load와 혼동을 줄 수 있다고 생각해서 "임포트"로 음차했습니다. 더 좋은 방법이나 선례가 있다면 조언 부탁드립니다.

기여자용

문서 개선

Progress

@prayinforrain prayinforrain changed the title 📝Docs : 05-version-11 03-pages > 01-building-your-application > 08-upgrading > 05-version-11 Jul 1, 2023
@prayinforrain prayinforrain changed the title 03-pages > 01-building-your-application > 08-upgrading > 05-version-11 03-pages > 01-building-your-application > 08-upgrading > 05-version-11.mdx Jul 1, 2023
@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jul 1, 2023
Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여 감사합니다!! 수정 사항 커멘트 드렸으니 확인 후 반영 부탁드립니다!

@prayinforrain
Copy link
Contributor Author

감사합니다! 피드백 주신 부분 반영했고 맞춤법 검사기로 일부 보정했습니다.

@chaejunlee chaejunlee self-requested a review July 26, 2023 06:06
Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 머지하도록 하겠습니다. 수고 많으셨습니다!!

@chaejunlee chaejunlee merged commit 4326833 into Nextjs-kr:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

05-version-11.mdx
3 participants