Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script: generate tx for product types #892

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

danoctavian
Copy link
Contributor

@danoctavian danoctavian commented Jul 4, 2023

Context

Create a standalone-script to add new product types that also handles IPFS downloads.

Changes proposed in this pull request

Modify the migration script to handle this functionality.

Test plan

Manual testing.

Checklist

  • Rebased the base branch
  • Attached corresponding Github issue
  • Prefixed the name with the type of change (i.e. feat, chore, test)
  • Performed a self-review of my own code
  • Followed the style guidelines of this project
  • Made corresponding changes to the documentation
  • Didn't generate new warnings
  • Didn't generate failures on existing tests
  • Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

  • 🍰 = Nice to have but not essential.
  • 💡 = Suggestion or a comment based on personal opinion
  • 🔨 = I believe this should be changed.
  • 🤔 = I don’t understand something, do you mind giving me more context?
  • 🚀 = Feedback

@danoctavian danoctavian force-pushed the feature/add-product-types-script branch 5 times, most recently from 65b8947 to fe17e73 Compare July 5, 2023 07:15
@danoctavian danoctavian changed the title wip product types Script: generate tx for product types Jul 5, 2023
@danoctavian danoctavian force-pushed the feature/add-product-types-script branch from fe17e73 to 914e58f Compare July 5, 2023 07:20
@roxdanila roxdanila merged commit 7798450 into release-candidate Jul 6, 2023
@roxdanila roxdanila deleted the feature/add-product-types-script branch July 6, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants